Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/integrations columns #5868

Open
wants to merge 51 commits into
base: master
Choose a base branch
from

Conversation

Npcodes1
Copy link

@Npcodes1 Npcodes1 commented Sep 7, 2024

Description

This PR fixes #5514. In the Home section of the src folder, I made edits to the index.js in the Playground-home folder. I added animation so that the icons in the integrations column would shift to a horizontal flow in mobile screen size, while still remaining vertical in tablet/desktop size.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Sep 7, 2024

🚀 Preview for commit e4fb8e1 at: https://66dbcf875e74a09f11ebd0e5--layer5.netlify.app

@Ashparshp
Copy link
Contributor

@Npcodes1, Thank you for your contribution! Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT). Please consider adding it as an agenda item to the meeting minutes || meeting link.

@Npcodes1
Copy link
Author

Npcodes1 commented Sep 7, 2024

@Ashparshp Thank you! I’m unable to make the meeting due to work but should I add it to the minutes anyways to be discussed without me? Also, do I need to worry about the MeshMap Screenshot Service failing?

@Ashparshp
Copy link
Contributor

@Npcodes1,

Thank you for your contribution! It’s great to see your updates. If you can’t attend the meeting, please do add the PR to the meeting minutes so it can be discussed in your absence. As for the failing MeshMap Screenshot Service, don’t worry about it—it’s not an issue related to your changes.

@Ashparshp
Copy link
Contributor

@Npcodes1, you've done a great job with the changes! Just a small request—please avoid altering linting like spaces or tabs, as it makes it a bit harder to review. It would be helpful to keep only the functional changes.

@Npcodes1
Copy link
Author

Npcodes1 commented Sep 9, 2024

Ok! Do I need to go make any changes?

@Ashparshp
Copy link
Contributor

@Npcodes1, please if you would then just update the functional changes and nothing.

@Npcodes1
Copy link
Author

Npcodes1 commented Sep 10, 2024

I updated it. Does this look better now? @Ashparshp

@l5io
Copy link
Contributor

l5io commented Sep 10, 2024

🚀 Preview for commit e5d7185 at: https://66dfdc7fac854a05d3eeb0d9--layer5.netlify.app

@vishalvivekm
Copy link
Member

@SAHU-01

Copy link
Contributor

@Ashparshp Ashparshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Npcodes1, LGTM!

@SAHU-01
Copy link

SAHU-01 commented Sep 13, 2024

Thank you so much for working on this @Npcodes1 , once you remove the commented code I believe we'll be really close to merging this PR 😉

@Npcodes1
Copy link
Author

@SAHU-01 Ok! I made changes but it rejected me using git push because my branch isn't up to date to the main one. It gave these suggestions. Does it matter which one I choose?
git config pull.rebase false # merge
git config pull.rebase true # rebase
git config pull.ff only # fast-forward only

@Ashparshp
Copy link
Contributor

@Npcodes1, use git config pull.rebase true. @SAHU-01, right?

@Npcodes1
Copy link
Author

Ok! Commented code has been removed. Please let me know if I missed anything.

@l5io
Copy link
Contributor

l5io commented Sep 16, 2024

🚀 Preview for commit d109db0 at: https://66e7d8fc23e323c810880fd2--layer5.netlify.app

@Npcodes1
Copy link
Author

I realized I forgot to sign my commit so I was going to do another commit but now I can't seem to run locally off Gitpod. It's giving me this error:
image

@vishalvivekm
Copy link
Member

I realized I forgot to sign my commit so I was going to do another commit but now I can't seem to run locally off Gitpod. It's giving me this error: image

please try running make clean

Copy link

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

1 similar comment
Copy link

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@l5io
Copy link
Contributor

l5io commented Sep 17, 2024

🚀 Preview for commit b9a756c at: https://66e9031e95a9cf7aa5e30ab7--layer5.netlify.app

@github-actions github-actions bot added project/meshery area/news A noteworthy article, event, happening area/blog New posts or new blog functionality area/community area/events labels Sep 17, 2024
leecalcote and others added 26 commits September 17, 2024 04:44
Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Nicole Payne <[email protected]>
Signed-off-by: Nicole Payne <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Nicole Payne <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Nicole Payne <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Nicole Payne <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Nicole Payne <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Nicole Payne <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Nicole Payne <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Nicole Payne <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Nicole Payne <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Nicole Payne <[email protected]>
Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Nicole Payne <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Nicole Payne <[email protected]>
Signed-off-by: Ashparsh Pandey <[email protected]>
Signed-off-by: Nicole Payne <[email protected]>
Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Nicole Payne <[email protected]>
Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Nicole Payne <[email protected]>
Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Nicole Payne <[email protected]>
Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Nicole Payne <[email protected]>
Bumps [@babel/cli](https://github.com/babel/babel/tree/HEAD/packages/babel-cli) from 7.22.5 to 7.25.6.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.25.6/packages/babel-cli)

---
updated-dependencies:
- dependency-name: "@babel/cli"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Nicole Payne <[email protected]>
Bumps [react-countdown](https://github.com/ndresx/react-countdown) from 2.3.5 to 2.3.6.
- [Release notes](https://github.com/ndresx/react-countdown/releases)
- [Commits](ndresx/react-countdown@v2.3.5...v2.3.6)

---
updated-dependencies:
- dependency-name: react-countdown
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Nicole Payne <[email protected]>
Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Nicole Payne <[email protected]>
@l5io
Copy link
Contributor

l5io commented Sep 17, 2024

🚀 Preview for commit 1bf546b at: https://66e90c6ede7b3f970c80c892--layer5.netlify.app

@Npcodes1
Copy link
Author

I fixed it.

@Npcodes1
Copy link
Author

@Ashparshp @SAHU-01 @vishalvivekm To resolve the conflicts should I change it to the master version (v0.2.12)?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Home] Integrations column not visible in mobile view in "Manage your cloud native mess" section
9 participants